Skip to content

AST-53: Pattern-matching objects#296

Merged
ggreif merged 70 commits intomasterfrom
gabor/object-matching
Apr 21, 2019
Merged

AST-53: Pattern-matching objects#296
ggreif merged 70 commits intomasterfrom
gabor/object-matching

Conversation

@ggreif
Copy link
Contributor

@ggreif ggreif commented Apr 6, 2019

https://dfinity.atlassian.net/browse/AST-53

In coverage.ml I am cutting corners, and reusing the infrastructure of plain products for labelled products, filling non-appearing field labels with wildcard patterns. I am interested to know whether you find this disgusting, I actually think it is cool. (I have changed nomenclature a bit to analyse products in general.)

Laundry list:

  • refactor code parts which deal with pattern lists
  • check whether there are simpler, more direct ways
  • rename selectors, to avoid the necessity of disambiguation
  • codegen
  • suppress actor matches (for now); checking mode: done, inferring: not possible?
  • suppress text, array matches this works now in frontend, codegen: done
  • fix sort inference for shared func (other PR?, later)
  • reject matching on mutable fields
  • disable repeated pattern fields (dubious feature, no coverage yet); added better error message.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants