Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dfinity.atlassian.net/browse/AST-53
Incoverage.mlI am cutting corners, and reusing the infrastructure of plain products for labelled products, filling non-appearing field labels with wildcard patterns. I am interested to know whether you find this disgusting, I actually think it is cool. (I have changed nomenclature a bit to analyse products in general.)Laundry list:
rename selectors, to avoid the necessity of disambiguationsuppress text, array matchesthis works now in frontend, codegen: doneshared func(other PR?, later)